Repository navigation
Conversation
WalkthroughThis pull request bumps the cryptomator package version from 1.18.0 to 1.18.1 across two packaging metadata files. Changes include updating the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@PKGBUILD`:
- Line 8: Update the PR description to explicitly state that you verified build
requirements for Cryptomator 1.18.1: confirm pkgver=1.18.1, `_jdkver=24.0.1+9`
matches upstream JDK 24 requirement, `_jfxver=25` artifacts are accessible, and
the Maven build configuration was tested; include brief notes about where you
checked upstream release notes and that no breaking changes were found so the
release checklist item can be closed.
|
|
||
| pkgname=cryptomator | ||
| pkgver=1.18.0 | ||
| pkgver=1.18.1 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Show pinned release + toolchain values in PKGBUILD
echo "=== PKGBUILD Pinned Values ==="
rg -n '^(pkgver|_jdkver|_jfxver)=' PKGBUILD || echo "No matches found"
# 2) Inspect upstream 1.18.1 release notes for Java/JDK/JavaFX/build requirement changes
echo "=== Upstream Release Notes ==="
curl -fsSL https://api.github.com/repos/cryptomator/cryptomator/releases/tags/1.18.1 \
| jq -r '.body' \
| rg -n -i 'java|jdk|jfx|javafx|build|packag' || echo "No relevant mentions found"
# 3) Verify currently pinned artifact URLs still resolve
echo "=== Artifact URL Status ==="
echo "Testing JDK URL..."
curl -fsSIL "https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24.0.1%2B9/OpenJDK24U-jdk_x64_linux_hotspot_24.0.1_9.tar.gz" | head -n 1 || echo "JDK URL check failed"
echo "Testing JFX URL..."
curl -fsSIL "https://download2.gluonhq.com/openjfx/25/openjfx-25_linux-x64_bin-jmods.zip" | head -n 1 || echo "JFX URL check failed"Repository: cryptomator/aur
Length of output: 410
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Check the PKGBUILD file structure and build instructions
echo "=== PKGBUILD Build Section ==="
sed -n '/^build()/,/^}/p' PKGBUILD | head -30
# Check dependencies
echo "=== PKGBUILD Dependencies ==="
grep -E '^(depends|makedepends|checkdepends)=' PKGBUILD
# Try alternative JDK URL approach with redirects allowed
echo "=== Testing JDK URL with redirects ==="
curl -fsSL -I "https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24.0.1%2B9/OpenJDK24U-jdk_x64_linux_hotspot_24.0.1_9.tar.gz" 2>&1 | head -5 || true
# Check if Cryptomator 1.18.1 specifies JDK version requirement
echo "=== Cryptomator 1.18.1 README/build info ==="
curl -fsSL https://raw.githubusercontent.com/cryptomator/cryptomator/1.18.1/README.md \
| rg -i 'java|jdk|require|version|build' | head -20 || echo "No build requirements found"Repository: cryptomator/aur
Length of output: 2386
Confirm JDK/JFX/build requirement checks in PR description.
The PKGBUILD pins appear correct for Cryptomator 1.18.1: _jdkver=24.0.1+9 matches upstream's JDK 24 requirement, _jfxver=25 is accessible, and the Maven build is properly configured. No breaking changes in upstream release notes. However, please explicitly document in the PR that these version/artifact checks were performed to formally close the release checklist items.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@PKGBUILD` at line 8, Update the PR description to explicitly state that you
verified build requirements for Cryptomator 1.18.1: confirm pkgver=1.18.1,
`_jdkver=24.0.1+9` matches upstream JDK 24 requirement, `_jfxver=25` artifacts
are accessible, and the Maven build configuration was tested; include brief
notes about where you checked upstream release notes and that no breaking
changes were found so the release checklist item can be closed.
Important
Todos: