Skip to content

Release 1.18.1 - #25

Closed
cryptobot wants to merge 1 commit into
masterfrom
release/1.18.1
Closed

cryptobot wants to merge 1 commit into
masterfrom
release/1.18.1

Conversation

@cryptobot

Copy link
Copy Markdown
Member

Important

Todos:

  • Update build instructions
  • Check for JDK update
  • Check for JFX update

@coderabbitai

coderabbitai Bot commented Feb 26, 2026

Copy link
Copy Markdown

Walkthrough

This pull request bumps the cryptomator package version from 1.18.0 to 1.18.1 across two packaging metadata files. Changes include updating the pkgver variable, modifying source URLs and filenames to reference the new tarball version, and updating SHA256 checksums to match the new release. No build logic, dependencies, or runtime behavior modifications are included.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Release 1.18.0 #20: Updates packaging metadata (pkgver, source URLs, sha256sums) for successive releases with identical change pattern.
  • Release: 1.18.0 No.2 #22: Prior version bump to 1.18.0 with the same metadata update structure.
  • Release 1.17.1 #19: Performs identical version bump and checksum update pattern for cryptomator package.

Suggested reviewers

  • SailReal
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Release 1.18.1' directly reflects the main change: updating the package version from 1.18.0 to 1.18.1 across both PKGBUILD and .SRCINFO files.
Description check ✅ Passed The description outlines the purpose of the PR (preparing release 1.18.1) and lists relevant pre-merge todos, which is directly related to the version bump changes in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/1.18.1

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@PKGBUILD`:
- Line 8: Update the PR description to explicitly state that you verified build
requirements for Cryptomator 1.18.1: confirm pkgver=1.18.1, `_jdkver=24.0.1+9`
matches upstream JDK 24 requirement, `_jfxver=25` artifacts are accessible, and
the Maven build configuration was tested; include brief notes about where you
checked upstream release notes and that no breaking changes were found so the
release checklist item can be closed.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe36d17 and 21882a4.

📒 Files selected for processing (2)
  • .SRCINFO
  • PKGBUILD

Comment thread PKGBUILD

pkgname=cryptomator
pkgver=1.18.0
pkgver=1.18.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# 1) Show pinned release + toolchain values in PKGBUILD
echo "=== PKGBUILD Pinned Values ==="
rg -n '^(pkgver|_jdkver|_jfxver)=' PKGBUILD || echo "No matches found"

# 2) Inspect upstream 1.18.1 release notes for Java/JDK/JavaFX/build requirement changes
echo "=== Upstream Release Notes ==="
curl -fsSL https://api.github.com/repos/cryptomator/cryptomator/releases/tags/1.18.1 \
  | jq -r '.body' \
  | rg -n -i 'java|jdk|jfx|javafx|build|packag' || echo "No relevant mentions found"

# 3) Verify currently pinned artifact URLs still resolve
echo "=== Artifact URL Status ==="
echo "Testing JDK URL..."
curl -fsSIL "https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24.0.1%2B9/OpenJDK24U-jdk_x64_linux_hotspot_24.0.1_9.tar.gz" | head -n 1 || echo "JDK URL check failed"

echo "Testing JFX URL..."
curl -fsSIL "https://download2.gluonhq.com/openjfx/25/openjfx-25_linux-x64_bin-jmods.zip" | head -n 1 || echo "JFX URL check failed"

Repository: cryptomator/aur

Length of output: 410


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Check the PKGBUILD file structure and build instructions
echo "=== PKGBUILD Build Section ==="
sed -n '/^build()/,/^}/p' PKGBUILD | head -30

# Check dependencies
echo "=== PKGBUILD Dependencies ==="
grep -E '^(depends|makedepends|checkdepends)=' PKGBUILD

# Try alternative JDK URL approach with redirects allowed
echo "=== Testing JDK URL with redirects ==="
curl -fsSL -I "https://github.com/adoptium/temurin24-binaries/releases/download/jdk-24.0.1%2B9/OpenJDK24U-jdk_x64_linux_hotspot_24.0.1_9.tar.gz" 2>&1 | head -5 || true

# Check if Cryptomator 1.18.1 specifies JDK version requirement
echo "=== Cryptomator 1.18.1 README/build info ==="
curl -fsSL https://raw.githubusercontent.com/cryptomator/cryptomator/1.18.1/README.md \
  | rg -i 'java|jdk|require|version|build' | head -20 || echo "No build requirements found"

Repository: cryptomator/aur

Length of output: 2386


Confirm JDK/JFX/build requirement checks in PR description.

The PKGBUILD pins appear correct for Cryptomator 1.18.1: _jdkver=24.0.1+9 matches upstream's JDK 24 requirement, _jfxver=25 is accessible, and the Maven build is properly configured. No breaking changes in upstream release notes. However, please explicitly document in the PR that these version/artifact checks were performed to formally close the release checklist items.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@PKGBUILD` at line 8, Update the PR description to explicitly state that you
verified build requirements for Cryptomator 1.18.1: confirm pkgver=1.18.1,
`_jdkver=24.0.1+9` matches upstream JDK 24 requirement, `_jfxver=25` artifacts
are accessible, and the Maven build configuration was tested; include brief
notes about where you checked upstream release notes and that no breaking
changes were found so the release checklist item can be closed.

@infeo infeo closed this Feb 26, 2026
@infeo
infeo deleted the release/1.18.1 branch February 26, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants