-
Notifications
You must be signed in to change notification settings - Fork 141
Failing browserstack test before main merge #4482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ethan-james
wants to merge
23
commits into
cybersemics:main
from
ethan-james:4394-failing-browserstack-test
+24
−3
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e87dc6b
Create iOS browserstack test
ethan-james eccf583
Check activeElemnt in browser.execute
ethan-james 83c35d5
Fix TransitionStyle error caused by radix-ui version bump
ethan-james eeb8621
Merge branch 'main' into 4394-bug-prevent-focus-on-non-cursor-thoughts
ethan-james 6225800
Move tap position right
ethan-james 560a62d
Increase lint:src old space size
ethan-james ddc823a
Nudge tap position right
ethan-james 74d3dd0
Merge branch 'main' into 4394-bug-prevent-focus-on-non-cursor-thoughts
ethan-james 465a826
Merge branch 'main' into 4394-bug-prevent-focus-on-non-cursor-thoughts
ethan-james d2a202c
Profile events in test
ethan-james 363ac00
Add more logging to browserstack test
ethan-james 866f831
Nudge tap position down
ethan-james 721993f
Remove redundant event profiling
ethan-james 25c17d8
Try to match touch event position in browserstack test
ethan-james dee9340
Tweak touch event position
ethan-james 48794ae
Use gesture in test to trigger compatability events
ethan-james 8050965
Nudge y position of gesture
ethan-james b24f377
Fix y position of gesture
ethan-james a2f9c78
Add pointerType option to tap helper
ethan-james 0573ddc
Nudge x position of tap
ethan-james a982645
Add y:60 to tap call in new test
ethan-james 786dc62
Failing browserstack test before main merge
ethan-james cbda577
Update test with click handler
ethan-james File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that
pointerType: 'mouse'solves a problem, but I'm concerned about the consequences of doing this in a mobile test. We want the iOS Appium tests to behave exactly like a touch device. It seems like settingpointerType: 'mouse'on a simulated touch device would create an artificial environment that doesn't reflect a real situation that could be encountered. This would put into question any test that uses this tap helper, because it's not guaranteed that an actual touch device would behave the same way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
pointerType: 'mouse'was hard-coded into the helper prior to this. It would probably be worthwhile to revisit the other tests that use the helper and see if they work withpointerType: 'touch'instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't realize we were already doing that in
main. Okay, something to keep in mind. Seems like a 🚩 at least.