Fix uncategorize undo save error#4528
Merged
raineorshine merged 2 commits intoJul 8, 2026
Merged
Conversation
Contributor
|
|
raineorshine
requested changes
Jul 7, 2026
raineorshine
left a comment
Contributor
There was a problem hiding this comment.
Fix looks good. Just some requests around test architecture.
raineorshine
approved these changes
Jul 7, 2026
BayuAri
approved these changes
Jul 8, 2026
BayuAri
left a comment
Collaborator
There was a problem hiding this comment.
Error is no longer prompted after Undo the Uncategorize with auto merged duplicate parent.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4425.
This fixes a crash/save error when uncategorizing a duplicated uncle thought and then undoing the change.
Problem
For a tree like:
Uncategorizing
b/aand then undoing could produce:The visible tree operation was mostly correct, but the undo persistence path could enqueue malformed lexeme updates.
Changes
Testing
Passed:
yarn test src/actions/__tests__/uncategorize.ts src/commands/__tests__/uncategorize.ts src/commands/__tests__/undo-redo.tsyarn lint:tscyarn eslint src/redux-enhancers/undoRedoEnhancer.ts src/actions/uncategorize.ts src/actions/__tests__/uncategorize.ts src/commands/__tests__/uncategorize.ts