-
Notifications
You must be signed in to change notification settings - Fork 306
Add pipeline-based configuration format (v2) with migration support #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dadoonet
wants to merge
17
commits into
master
Choose a base branch
from
feature/pipeline-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fb3996c
Phase 1: Add pipeline configuration classes
dadoonet 9a21db0
Phase 2: Add FsSettingsMigrator for settings format migration
dadoonet debc597
Phase 3: Integrate migration into FsSettingsLoader
dadoonet c37e41e
Phase 4: Add pipeline plugin interfaces
dadoonet 6237c7d
Phase 5: Add abstract base classes for pipeline plugins
dadoonet 7c9ca3e
Phase 6: Add Pipeline and PipelinePluginsManager
dadoonet 6c4c9a8
Phase 7: Add --migrate CLI option for configuration migration
dadoonet ec8ef70
Phase 8: Add unit tests for pipeline migration
dadoonet 458df01
Phase 9: Integrate MVEL for conditional routing in pipeline
dadoonet 9ad275e
Add documentation for pipeline v2 configuration format
dadoonet bea1754
Add integration tests for pipeline v2 configuration
dadoonet 09920f4
Remove singular syntax support for pipeline configuration
dadoonet 24280e5
Add split configuration support and improve migrate CLI
dadoonet 4780914
Use component type in split configuration filenames
dadoonet 1e3d0b3
Simplify split configuration generation
dadoonet 2fb7eee
Make migration interactive with preview and confirmation
dadoonet 0b4341a
Detect output type by checking path existence
dadoonet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration ignores user-specified output path when non-existent
Medium Severity
When
--migrate-outputspecifies a path that doesn't exist, the user's path is completely discarded and replaced with the hardcoded default_settings/directory. For example, running--migrate-output my_config.yamlwhenmy_config.yamldoesn't exist will create_settings/directory instead of the specified file. The documentation example showing single-file output (--migrate-output _settings_v2.yaml) will only work if the file pre-exists, which is counterintuitive and silently ignores user intent.