Repository navigation
Test missing-path validation API and document discovery timing - #1975
Merged
yarikoptic merged 1 commit intoNov 3, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1975 +/- ##
==========================================
+ Coverage 91.04% 91.09% +0.05%
==========================================
Files 95 95
Lines 14599 14608 +9
==========================================
+ Hits 13291 13307 +16
+ Misses 1308 1301 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yarikoptic
approved these changes
Nov 3, 2026
Member
|
Thank you @AtomicGlance |
Contributor
Author
It's an honor Dr. Yarik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1932, addressing the two points in @yarikoptic-gitmate's review.
dandi.validate._core.validate()API with missing NWB paths passed as bothstrandPath. The existing CLI test stops in Click before reaching this code.find_dandi_files()is a generator: it checks requested paths on first iteration, before yielding a file. Add aversionchangednote for the missing-path behavior.I left upload-path handling to #1974 as suggested.
Validation: 11 focused tests passed (new API cases plus existing discovery and CLI cases); flake8 and
git diff --checkpassed. This does not claim a full-suite run.