Skip to content

Test missing-path validation API and document discovery timing - #1975

Merged
yarikoptic merged 1 commit into
dandi:masterfrom
AtomicGlance:followup-1932-validation-api-docs
Nov 3, 2026
Merged

yarikoptic merged 1 commit into
dandi:masterfrom
AtomicGlance:followup-1932-validation-api-docs

Conversation

@AtomicGlance

Copy link
Copy Markdown
Contributor

Follow-up to #1932, addressing the two points in @yarikoptic-gitmate's review.

  • Test the Python dandi.validate._core.validate() API with missing NWB paths passed as both str and Path. The existing CLI test stops in Click before reaching this code.
  • Clarify that find_dandi_files() is a generator: it checks requested paths on first iteration, before yielding a file. Add a versionchanged note for the missing-path behavior.

I left upload-path handling to #1974 as suggested.

Validation: 11 focused tests passed (new API cases plus existing discovery and CLI cases); flake8 and git diff --check passed. This does not claim a full-suite run.

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.09%. Comparing base (4e9bb5c) to head (ae1d41a).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1975      +/-   ##
==========================================
+ Coverage   91.04%   91.09%   +0.05%     
==========================================
  Files          95       95              
  Lines       14599    14608       +9     
==========================================
+ Hits        13291    13307      +16     
+ Misses       1308     1301       -7     
Flag Coverage Δ
unittests 91.09% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic added the documentation Changes only affect the documentation label Nov 3, 2026
@yarikoptic

Copy link
Copy Markdown
Member

Thank you @AtomicGlance

@yarikoptic
yarikoptic merged commit 54e842c into dandi:master Nov 3, 2026
38 of 39 checks passed
@AtomicGlance

Copy link
Copy Markdown
Contributor Author

Thank you @AtomicGlance

It's an honor Dr. Yarik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Changes only affect the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants