Erase formatting after failed format --replace#18446
Conversation
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
|
Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18446/1/testReport/ |
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18446/1/execution/node/983/log |
| cmd.Debugf("Invoking SystemErase to clean up after failed format operation") | ||
|
|
||
| eraseReq := &control.SystemEraseReq{} | ||
| eraseResp, err := control.SystemErase(ctx, cmd.ctlInvoker, eraseReq) |
There was a problem hiding this comment.
I don't think this will work... SystemErase doesn't allow you to choose ranks or nodes.
I think you'll need to handle this from the daos_server that owns the engine. If the engine fails to join, and it's a replace operation, blow the storage away. The failure that triggered this request was happening at the join stage.
If the format itself fails, I don't think there's any risk of the engine coming up. If there's a partial failure, it's not a bad idea to clean up, but I think that would have to happen from the server side, too.
Steps for the author:
After all prior steps are complete: