Placement -> Scheduler CLI Changes - #1692
Open
cicoyle wants to merge 2 commits into
Open
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the self-hosted initialization flow to support running actor placement via the scheduler (instead of the standalone placement service), and adjusts related CLI behaviors and certificate renewal restarts accordingly.
Changes:
- Add
--scheduler-placementtodapr initand propagate it into standalone init behavior. - Skip running/installing placement (container and slim binary) when scheduler placement is enabled, and enable placement in the scheduler container.
- Include the scheduler StatefulSet in control-plane restarts during certificate renewal, skipping restarts for workloads that are not deployed.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/standalone/standalone.go | Adds scheduler-placement capability checks, wiring, and container/binary behavior changes. |
| pkg/standalone/standalone_test.go | Adds unit tests for scheduler-placement version gating. |
| cmd/renew_certificate.go | Restarts scheduler StatefulSet (when present) during certificate renewal. |
| cmd/init.go | Adds the --scheduler-placement flag and passes it to standalone init. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placement -> Scheduler CLI Changes