Do not override library edit history from XMP sidecar file when using darktable-cli#21488
Open
da-phil wants to merge 2 commits into
Open
Do not override library edit history from XMP sidecar file when using darktable-cli#21488da-phil wants to merge 2 commits into
da-phil wants to merge 2 commits into
Conversation
When darktable-cli is executed via the --library <db> and the file to be exported has an associated (potentially stale) XMP sidecar file, the library history stack gets overridden. This change proposes to prefer the library database history entry over an existing XMP sidecar file once the --library argument is provided to darktable-cli.
da-phil
force-pushed
the
xmp_history_stack_overrides_library_bugfix
branch
from
c1a11ba to
8ff4464
Compare
da-phil
changed the title
Collaborator
|
I didn't check this in source but - what about the memory database? That's safe i guess? |
Contributor
Author
|
Good point, thought about this too. |
Contributor
Author
|
Well, I just made extra sure that we do not have to deal with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When darktable-cli is executed via the
--library <db>and the RAW file to be exported has an associated (potentially stale) XMP sidecar file, the library history stack gets overridden. This change proposes to prefer the library database history entry over an existing XMP sidecar file once the--libraryargument is provided to darktable-cli.