masks: Rework the mask handling/edting when collapsing mask manager.#21502
Open
TurboGit wants to merge 5 commits into
Open
masks: Rework the mask handling/edting when collapsing mask manager.#21502TurboGit wants to merge 5 commits into
TurboGit wants to merge 5 commits into
Conversation
TurboGit
added
bugfix
Collaborator
|
I just tested it, there are possibly some corner cases that i might have missed but so far all good :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to simplify the code in darkroom and moreover
is cleaner as the actual check is done at the right place.
This fixes the scroll, click, release events when mask manager is
closed.
Fixes #21436
Some notes on implementation:
To avoid messing with the state of mask manager and/or actual expanded and focused modules I have introduced a new "expanded_state" callback (hook) for lib modules. This is called each time a module is either expanded or collapsed. It is using this hook that the mask manager check if the shapes being edited are to be hidden or kept if the iop module is using them.