fix(platform-wallet): auto_select_inputs honors Σ inputs == Σ outputs

.github/package-filters/rs-packages-no-workflows.yml

@@ -99,3 +99,7 @@ wasm-sdk:
   - packages/wasm-sdk/src/**
   - packages/wasm-sdk/Cargo.toml
   - *sdk
+
+rs-platform-wallet:
+  - packages/rs-platform-wallet/**
+  - *sdk

packages/rs-platform-wallet/src/changeset/core_bridge.rs

@@ -129,8 +129,8 @@ async fn build_core_changeset(
             addresses_derived,
             ..
         } => {
-            // Derive UTXO deltas BEFORE moving the record into `records`
-            // so we still have the per-record borrows.
+            // Derive UTXO deltas before moving the record into `records`
+            // so the per-record borrows are still live.
             CoreChangeSet {
                 new_utxos: derive_new_utxos(record),
                 spent_utxos: derive_spent_utxos(record),

packages/rs-platform-wallet/src/error.rs

@@ -1,3 +1,4 @@
+use dpp::address_funds::PlatformAddress;
 use dpp::identifier::Identifier;
 use key_wallet::Network;
 
@@ -72,6 +73,16 @@ pub enum PlatformWalletError {
     #[error("Address operation failed: {0}")]
     AddressOperation(String),
 
+    #[error("Arithmetic overflow on Credits in {context}")]
+    ArithmeticOverflow { context: String },
+
+    #[error(
+        "all funded addresses are also outputs of this transfer: {outputs:?}; \
+         either rotate to a fresh receive address or use \
+         InputSelection::Explicit and split the operation"
+    )]
+    OnlyOutputAddressesFunded { outputs: Vec<PlatformAddress> },
+
     #[error("Platform address not found in wallet: {0}")]
     AddressNotFound(String),
 

packages/rs-platform-wallet/src/manager/accessors.rs

@@ -347,10 +347,10 @@ impl<P: PlatformWalletPersistence + 'static> PlatformWalletManager<P> {
         // through a helper on the manager — since the registry itself
         // isn't exposed, fall back to "0" until a sync getter is
         // added. This is intentionally a TODO surface, not a guess.
-        let queue_depth = match self.identity_sync_manager.try_queue_depth() {
-            Some(n) => n,
-            None => 0,
-        };
+        let queue_depth = self
+            .identity_sync_manager
+            .try_queue_depth()
+            .unwrap_or_default();
         IdentitySyncConfigSnapshot {
             interval_seconds: interval.as_secs().max(1),
             queue_depth,
@@ -702,7 +702,7 @@ impl<P: PlatformWalletPersistence + 'static> PlatformWalletManager<P> {
             .map(|(reg_idx, managed)| {
                 use dpp::identity::accessors::IdentityGettersV0;
                 WalletIdentityRowSnapshot {
-                    registration_index: *reg_idx as u32,
+                    registration_index: *reg_idx,
                     identity_id: managed.identity.id().to_buffer(),
                 }
             })
@@ -739,11 +739,7 @@ fn pool_snapshot(pool: &AddressPool) -> AccountAddressPoolSnapshot {
         AddressPoolType::AbsentHardened => 3,
     };
     let last_used_index: i64 = pool.highest_used.map(|i| i as i64).unwrap_or(-1);
-    let addresses = pool
-        .addresses
-        .values()
-        .map(|info| addr_info_snapshot(info))
-        .collect();
+    let addresses = pool.addresses.values().map(addr_info_snapshot).collect();
     AccountAddressPoolSnapshot {
         pool_type,
         gap_limit: pool.gap_limit,

packages/rs-platform-wallet/src/wallet/apply.rs

@@ -307,8 +307,6 @@ impl PlatformWalletInfo {
         drop(token_balances);
 
         // 7. Recompute cached UI balance from the now-restored UTXO set.
-        //    `update_balance` returns its own changeset internally; we
-        //    discard it (apply does not re-emit).
         use key_wallet::wallet::managed_wallet_info::wallet_info_interface::WalletInfoInterface;
         self.core_wallet.update_balance();
         // Mirror the recomputed balance into the lock-free Arc that the