Skip to content

refactor: structure v1 getDocuments where/order_by/having as typed proto messages #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 21 commits into from
May 17, 2026

fix: classify GROUP BY + SELECT DOCUMENTS as InvalidArgument

ec06ee6
Select commit
Loading
Failed to load commit list.
Merged

refactor: structure v1 getDocuments where/order_by/having as typed proto messages #3654

fix: classify GROUP BY + SELECT DOCUMENTS as InvalidArgument
ec06ee6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 17, 2026 in 0s

88.07% (-0.08%) compared to d7f22f9

View this Pull Request on Codecov

88.07% (-0.08%) compared to d7f22f9

Details

Codecov Report

❌ Patch coverage is 55.72519% with 290 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.07%. Comparing base (d7f22f9) to head (ec06ee6).
⚠️ Report is 1 commits behind head on v3.1-dev.

Files with missing lines Patch % Lines
...ve-abci/src/query/document_query/v1/conversions.rs 37.73% 132 Missing ⚠️
...s/rs-drive-abci/src/query/document_query/v1/mod.rs 79.42% 43 Missing ⚠️
packages/rs-drive/src/query/mod.rs 44.44% 30 Missing ⚠️
packages/rs-drive/src/query/projection.rs 28.57% 30 Missing ⚠️
...s/rs-drive-abci/src/query/document_query/v0/mod.rs 73.95% 25 Missing ⚠️
...s-drive-proof-verifier/src/proof/document_count.rs 0.00% 22 Missing ⚠️
...ery/drive_document_count_query/drive_dispatcher.rs 38.46% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           v3.1-dev    #3654      +/-   ##
============================================
- Coverage     88.15%   88.07%   -0.08%     
============================================
  Files          2515     2521       +6     
  Lines        307979   308681     +702     
============================================
+ Hits         271507   271879     +372     
- Misses        36472    36802     +330
Components Coverage Δ
dpp 88.01% <ø> (+0.01%) ⬆️
drive 87.07% <41.37%> (-0.08%) ⬇️
drive-abci 90.05% <61.31%> (-0.18%) ⬇️
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value 92.17% <ø> (ø)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier 53.22% <0.00%> (-0.41%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov