feat: add transaction related method - #360
Conversation
|
So strange, I run |
48d0780 to
17da5f4
Compare
78d279f to
60a1b79
Compare
| } | ||
|
|
||
| async fn begin(&self) -> Result<()> { | ||
| let _ = self.exec("BEGIN").await; |
2be8397 to
f6e3db8
Compare
| let (val,): (i32,) = row.try_into().unwrap(); | ||
| assert_eq!(val, 1); | ||
|
|
||
| conn.rollback().await.unwrap(); |
There was a problem hiding this comment.
Should recheck after rollback?
|
Review result: closing this PR. Reason: This PR has not been updated for a long time and is currently in conflict with main (CONFLICTING/DIRTY). The existing implementation also left review comments about transaction error handling and rollback verification unresolved, so it does not form a mergeable final version. If transaction support is still needed, please submit a new PR based on the current Connection/IConnection structure, with proper error propagation for REST/FlightSQL and dedicated tests for commit and rollback behavior. Thanks for the contribution; feel free to reopen the discussion or submit a new PR. |
3 participants
begin,commit,rollbacktransaction method.