feat: implement replace_children for custom ExecutionPlan nodes - #669
Open
VedantMadane wants to merge 2 commits into
Open
VedantMadane wants to merge 2 commits into
VedantMadane wants to merge 2 commits into
Conversation
gabotechs
reviewed
Aug 24, 2026
Comment on lines
+179
to
+186
| fn replace_children( | ||
| self: Arc<Self>, | ||
| children: Vec<Arc<dyn ExecutionPlan>>, | ||
| _options: ReplaceChildrenOptions, | ||
| ) -> Result<Arc<dyn ExecutionPlan>> { | ||
| // Prefer replace_children over deprecated with_new_children (#657). | ||
| self.with_new_children(children) | ||
| } |
Collaborator
There was a problem hiding this comment.
@VedantMadane I'm afraid this is not sufficient. The point of this is to stop using with_new_children, but in this PR you are still using it everywhere.
VedantMadane
force-pushed
the
fix/issue-657
branch
from
September 9, 2026 13:18
35c633d to
135017b
Compare
|
Hello, is this open? |
VedantMadane
force-pushed
the
fix/issue-657
branch
2 times, most recently
from
September 22, 2026 06:12
c75f4d9 to
554452b
Compare
- src/coordinator/distributed.rs: replace_children -> with_new_children - src/execution_plans/broadcast.rs: replace_children -> with_new_children - src/execution_plans/children_isolator_union.rs: replace_children -> with_new_children - src/execution_plans/distributed_leaf.rs: replace_children -> with_new_children - src/execution_plans/metrics.rs: replace_children -> with_new_children - src/execution_plans/network_broadcast.rs: replace_children -> with_new_children - src/execution_plans/network_coalesce.rs: replace_children -> with_new_children - src/execution_plans/network_shuffle.rs: replace_children -> with_new_children - src/execution_plans/sampler.rs: replace_children -> with_new_children - src/explain_analyze.rs: replace_children -> with_new_children - src/test_utils/mock_exec.rs: replace_children -> with_new_children - src/test_utils/routing.rs: replace_children -> with_new_children - src/test_utils/test_work_unit_feed.rs: replace_children -> with_new_children - examples/custom_execution_plan.rs: replace_children - examples/custom_worker_url_routing.rs: replace_children - examples/work_unit_feed.rs: replace_children - tests/custom_config_extension.rs: replace_children - tests/custom_extension_codec.rs: replace_children - tests/error_propagation.rs: replace_children - tests/stateful_execution_plan.rs: replace_children - benchmarks/benches/broadcast_cache_scenarios.rs: replace_children Fixes datafusion-contrib#657 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
VedantMadane
force-pushed
the
fix/issue-657
branch
from
September 23, 2026 07:48
36a9838 to
7799a86
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: implement replace_children for custom ExecutionPlan nodes
Changes
Fixes #657