Skip to content

fix: finalize metrics for unexecuted tasks (#739) - #752

Merged
gabotechs merged 2 commits into
datafusion-contrib:mainfrom
sesteves:fix/unexecuted-task-metrics-finalization
Sep 26, 2026
Merged

gabotechs merged 2 commits into
datafusion-contrib:mainfrom
sesteves:fix/unexecuted-task-metrics-finalization

Conversation

@sesteves

@sesteves sesteves commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • When a worker channel ends without a final report, complete the planned task with an empty metrics or dynamic-filter report.
  • Skip plan-node metric rewriting for unexecuted tasks rather than inventing execution metrics.
  • Enable the regression test from fix: add ignored regression test for metrics finalization (#739) #751 and verify both rewrite paths after an AQE task is left unexecuted. Static and adaptive planning share this coordinator receive path.

Tested on devspace: 15 metrics integration tests, four dynamic-filter integration tests, and two dynamic-filter display unit tests pass; formatting passes.

Fixes #739

@gabotechs gabotechs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks @sesteves, just left some cosmetic suggestions, but this looks good.

Comment thread src/coordinator/query_coordinator.rs Outdated
Comment thread src/metrics/task_metrics_rewriter.rs
@gabotechs
gabotechs merged commit 6a038f2 into datafusion-contrib:main Sep 26, 2026
35 checks passed
@gabotechs

Copy link
Copy Markdown
Collaborator

Thanks @sesteves!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics finalization can hang on planned but never executed tasks with AQE or static planning

2 participants