Skip to content

fix: harden Asana link-check workflow against false rejections and API timeouts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachelauryn merged 2 commits into from
Jul 28, 2026
Merged

fix: harden Asana link-check workflow against false rejections and API timeouts #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ab655
fix: don't let flaky Asana API block PR merges
Jul 28, 2026
7276dfd
fix: accept Asana task links copied without a project segment
Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/link-asana-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,21 @@ jobs:
with:
script: |
const body = context.payload.pull_request.body || "";
const urlPattern = /https:\/\/app\.asana\.com\/(?:0\/(?:0|[0-9]+)\/(?:task\/)?([0-9]+)|1\/[0-9]+\/project\/[0-9]+\/task\/([0-9]+))/i;
// Accepts both legacy (app.asana.com/0/...) and current-UI
// (app.asana.com/1/<workspace>/[project/<id>/]task/<id>) permalinks.
// The project segment is optional: Asana omits it when a task link is
// copied from a project-less context (My Tasks, Inbox, search, etc).
const urlPattern = /https:\/\/app\.asana\.com\/(?:0\/(?:0|[0-9]+)\/(?:task\/)?([0-9]+)|1\/[0-9]+\/(?:project\/[0-9]+\/)?task\/([0-9]+))/i;
if (!body.match(urlPattern)) {
core.setFailed("PR description must include an Asana task URL.");
}

# Best-effort: this only links the PR as an Asana attachment, it doesn't gate
# the merge requirement above. The Asana API is occasionally slow/unresponsive,
# so we cap the wait and don't let a flaky third-party call block merges.
- if: steps.gate.outputs.skip != 'true'
timeout-minutes: 2
continue-on-error: true
uses: Asana/create-app-attachment-github-action@v1.3
with:
asana-secret: ${{ secrets.ASANA_SECRET }}