Repository navigation
chore(standards): sync CI fixes and upgrade Bun to 1.4.3 - #209
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before. Wordhold ran the canonical Standards files of 11 October, because the weekly standards sync has failed since 5 October. It therefore lacked several later CI fixes: a push to a draft PR directly followed by ready for review could cancel the ready run, as in run 38624481042, and leave the head without its required check. The CI Postgres also synced every write to disk, so each
DROP DATABASEin the test suites took seconds. Bun 1.4.2 has a JIT bug that desynchronizesError.stackTraceLimit. Locally, a changing host network address could make Chromium abort accessibility-test requests withnet::ERR_NETWORK_CHANGED.Now. Wordhold uses the current canonical files, Standards CLI 0.30.0, and Bun 1.4.3 in the dev shell, CI, and the runtime image. Draft and ready runs no longer cancel each other (standards#437). Both CI Postgres services run without disk syncs (standards#439), and Bun 1.4.3 fixes the JIT bug (standards#436). The accessibility suite runs through
a11y-playwright, which uses a loopback-only network namespace where the host allows it (standards#431).Implementation
test:a11yrunsa11y-playwrightbecause the fixture server is a staticvite previewthat needs no host network. The CLI moves to 0.30.0 because the structure check in 0.29.0 accepts onlyplaywright testthere.bun installdoes not add a newbinof an existing workspace package tobun.lock, and--frozen-lockfiledoes not notice its absence. The threebinlines for@davidvornholt/a11y-testingwere added by hand, exactly as in the Standards lockfile;bun install --frozen-lockfilethen linksnode_modules/.bin/a11y-playwright.oven/bun:1.4.3.container-smokejob inpublish-container.ymlruns the full gate against its own Postgres service, which gets the samePOSTGRES_INITDB_ARGS.@types/bunstays^1.4.2, as in the canonical packages.Verification
Completed checks
bun run checkon the final commit, withDATABASE_URLfromapps/web/.env.local:standards checkpassed (63 canonical paths match, structure matches), and all 15 Turbo tasks passed. An uncached run on the same content passed all 15 tasks in 38.8 s: web 932 tests, db 28, ai 188, a11y-testing 21.bun run test:a11yinapps/web: 524 passed in 35.6 s inside the loopback-only namespace, without the fallback notice.podman buildof the Dockerfile succeeded, andbun --versionin the image prints1.4.3.container-smokechecks, replayed with Podman againstpostgres:18-alpinestarted with the newPOSTGRES_INITDB_ARGS:fsync,synchronous_commit, andfull_page_writesreadoff;db:migrate:productionpassed twice; the read-only container without capabilities answered/api/healthwith{"status":"ok"}as user65532:65532.