Raise the external-editor behave timeouts to reduce CI flakiness - #1619
Open
DiegoDAF wants to merge 1 commit into
Open
Raise the external-editor behave timeouts to reduce CI flakiness#1619DiegoDAF wants to merge 1 commit into
DiegoDAF wants to merge 1 commit into
Conversation
The `edit sql in file with external editor` scenario intermittently errors on CI: `expect_exact` waits only 2 seconds for the ex-mode banner (and 1 second per token when checking the resulting prompt), which is not always enough on a loaded runner. behave then reports the scenario as an error and fail-fast cancels the sibling matrix jobs, which looks like a systematic breakage. Raise the timeouts in tests/features/steps/iocommands.py to 10 seconds. This does not slow down passing runs: pexpect returns as soon as the expected text appears, so the timeout only bounds how long a failing wait blocks.
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Aug 18, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
edit sql in file with external editorscenario intests/features/iocommands.featureerrors intermittently on CI. It is a timingissue, not a real failure:
expect_exactwaits only 2 seconds for the ex-modebanner (and 1 second per token when checking the resulting prompt), which is
not always enough on a loaded runner.
When it expires, behave reports the scenario as an error and fail-fast then
cancels the sibling matrix jobs, so a single slow wait looks like a systematic
breakage across Python versions.
Recent examples: it hit #1543 on 3.10, #1544 and #1609 on other versions (both
went green on a later run with no code change), and my own fork's CI on commits
that touch nothing near the editor code. @j-bennet asked about exactly this in
#1543.
Change
Raise the
expect_exacttimeouts intests/features/steps/iocommands.pyto 10seconds (from 2s, 1s and 5s).
This does not slow down passing runs: pexpect returns as soon as the expected
text appears, so the timeout only bounds how long a failing wait blocks
before behave gives up.
Validation
behave features/iocommands.featuregreen locally (2 scenarios, 12 steps), andthe full behave suite green as well (15 features, 61 scenarios, 0 failed). The
scenario has been stable in my fork since the change.
Checklist
changelog.rst.Not a feature from my list in discussion #1603: this is one of the upstream bugs I ran into while maintaining the fork, listed in the status section at the bottom of that discussion.