fix(widget-list): restore controls for erroneous typed items - #7988
Open
sridharkalaibala wants to merge 1 commit into
Open
fix(widget-list): restore controls for erroneous typed items#7988sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
✅ Deploy Preview for decap-cms ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7973. Editors can once again remove list items whose type is missing or unknown, while respecting the list's
allow_removeandallow_reordersettings.The erroneous-item path now passes those flags to the real top bar. It also passes the click event correctly to
handleRemove(the old extra key argument would make clicking the restored button throw atevent.preventDefault()) and uses the list's stored key as the sortable row and handle ID.Test plan
pnpm testpassed: repository lint, formatting, TypeScript check, four Cypress-runner tests, and Jest (113 passing suites, 1,390 passing tests, 138 passing snapshots; 2 suites and 1,304 tests skipped by the existing suite).Validated on Windows with Node 24 and pnpm 11.12.0. Browser drag gestures and the full Cypress E2E suite were not run; control rendering and deletion are exercised in jsdom. No dependency or lockfile changes.
Prepared with AI assistance and validated locally.
Checklist