[dmt] collect mount files#418
Merged
Merged
Conversation
Signed-off-by: diyliv <onlogn081@gmail.com>
ldmonster
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filessection in mount-points.yaml: themount-pointscontainer rule only collecteddirs, ignoringfilesentries.Files []stringfield tomountPointsFilestruct and iterate overmpf.Filesalongsidempf.DirsincollectMountPointsDirs.TestMountPointsContainerRule_FilesDeclaredcoveringfilessection.pkg/linters/container/rules/mount_points.go,pkg/linters/container/rules/mount_points_test.goContext
The
mount-pointsrule requires everyvolumeMount.mountPathin Deployment/DaemonSet/StatefulSet to be declared in amount-points.yaml. However,mount-points.yamlsupports bothdirsandfilessections, but the linter only readdirs. This caused false positives for mount paths declared as files (e.g.,/etc/app/config.yaml,/run/xtables.lock) — the linter warned they were "not declared" even though they were present infiles.Example
Before (false positive):
Even though
mount-points.yamlcontains:After: no warning — file mount paths are recognized.