wallet/udb: remove unused UTXO value assignment - #2651
Open
daixiheguu wants to merge 1 commit into
Open
Conversation
Signed-off-by: daixiheguu <daixihegu@outlook.com>
jholdstock
reviewed
Aug 29, 2026
jholdstock
left a comment
jholdstock
left a comment
Member
There was a problem hiding this comment.
I'd go one step further with this and move the declaration of v down to where it is actually used (just above if !unmined).
The copyright header should also be updated to 2026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discard the value returned by
randomUTXOin the mined-transaction test helper because the value is unconditionally replaced bybucket.Get(k)before it can be read.The key selection remains unchanged, while the code no longer suggests that the original value is used and staticcheck
SA4006is resolved.Tested with: