Reduce request read limit from 4MiB to 1MiB. - #529
Merged
Merged
Conversation
4MiB was set as a read limit somewhat arbitrarily, just to ensure there is some limit in place rather than allowing unlimited reads. This can be reduced to 1MiB and still comfortably fit a request containing even the maximum possible transaction hex. Note that the comment here which stated 2MiB was incorrect and the actual value in use was 4MiB.
davecgh
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4MiB was set as a read limit somewhat arbitrarily, just to ensure there is some limit in place rather than allowing unlimited reads. This can be reduced to 1MiB and still comfortably fit a request containing even the maximum possible transaction hex.
Note that the comment here which stated 2MiB was incorrect and the actual value in use was 4MiB.