Repository navigation
fix(master): enforce admission for pinned sandbox placement - #441
Open
Floating-Y wants to merge 1 commit into
Open
Floating-Y wants to merge 1 commit into
Floating-Y wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /v1/sandboxes accepted explicit node_id placement without checking whether the node was connected, admitting work, switching backends, or able to fit the whole batch. Source-pinned snapshot forks used the same path.
Route Place::Node through pick_node_where with candidates restricted to the requested ID and the full batch count. Successful creates use the node's actual pool; unavailable targets return the scheduler's 503 and increment refused once per request. Preserve existing template/backend/snapshot compatibility 409s, max_sandboxes=0 semantics, and transaction boundaries.
Extend the existing capacity regression matrix across pool placement, explicit template placement, and implicit/explicit source-pinned snapshot forks. Verify missing/offline targets, no rerouting to a healthy spare, exact remaining capacity, resource admission, and unchanged sandbox records, gateway ports, and network slots after refusal.
Validation in WSL Ubuntu:
Based on dev at d27ab7c.