Repository navigation
fix: bind snapshot tag caches to immutable creation IDs - #444
Open
Floating-Y wants to merge 1 commit into
Open
Floating-Y wants to merge 1 commit into
Floating-Y wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting and recreating a snapshot tag can leave another node restoring the previous image from its name-only cache, even when the master selects the correct new source. Keep the public tag-name API and bind each creation to an immutable snapshot ID instead.
Regression coverage
No KVM required. Reuse the master HTTP and node TLS transfer tests, with a fake backend that reads the image opened by the real
Runtime::create -> Backend::restorepath.Covers A-to-C source replacement, same-source recreation, late old transfers, delayed cleanup, occupied publication destinations, failed new transfers, legacy migration, and a second fork with no additional downloads. Both name-reuse regressions failed before the fix on
old != newafter source selection passed. The concurrent-branch test also failed before its guard (201instead of409).Validation
cargo test -p sandstorm-core --quiet -- --test-threads=2: 423 passed.cargo clippy -p sandstorm-core --all-targets --all-features -- -D warnings: passed.cargo fmt --all -- --checkandgit diff --check: passed.An initial parallel full-suite run hit the unchanged gateway startup timing assertion (620 ms versus a 600 ms limit); it passed individually and in the full rerun. No KVM or physical multi-node test was run. Upgrade the master and participating nodes together; old node binaries retain the original behavior.
Based on upstream
devatd27ab7c452126e3b34987b84d3c72cb41fc3fd16.