Skip to content

fix(sdk-python): encode snapshot tags in DELETE requests - #447

Open
Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/python-snapshot-tag
Open

Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/python-snapshot-tag

Conversation

@Maya-Kid

Copy link
Copy Markdown

Deleting checkpoint#draft through the Python SDK could silently delete checkpoint. Encode the tag as a single URL path segment so the request names the exact snapshot.

The HTTP regression tests verify that the requested snapshot disappears and the other snapshot remains. They cover #, ?, literal %23, Unicode, spaces, and a plain tag. All 41 SDK tests passed on both Python 3.9 and 3.12.

Signed-off-by: dada-yan <BinjunYann@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant