Repository navigation
Conversation
Signed-off-by: dada-yan <BinjunYann@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent runsc calls shared output files named after the daemon PID. A call could read another call's output, and a timed-out call left both files behind.
Give each call its own file-backed stdout and stderr capture and unlink both paths before spawning. Keeping the handles open preserves capture without waiting for EOF from inherited pipes.
Two regression tests force concurrent calls to overlap and verify each captured result, then check that a timed-out call leaves the temporary directory empty. Both fail on the original code. On macOS, all 410 Rust tests passed along with build, Clippy, and formatting checks. The regressions use a fake runsc executable.