Skip to content

fix(console): preserve snapshot builds when cleanup fails - #450

Open
Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/console-build-cleanup
Open

Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/console-build-cleanup

Conversation

@Maya-Kid

Copy link
Copy Markdown

The snapshot builder reported a build sandbox as deleted and cleared its session even when DELETE returned an error. Check the response, report the error, and retain the session until deletion succeeds.

After the snapshot is saved, the retry action sends only DELETE, including after a page reload. A failed manual discard also keeps the session available for retry.

Three component regression tests cover failed cleanup, retry after reload, and failed manual discard. All 15 console tests and the production build passed on Node 22.

Signed-off-by: dada-yan <BinjunYann@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant