Skip to content

fix(templates): honor corrected args on pending image retries - #452

Open
Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/image-template-retry-args
Open

Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/image-template-retry-args

Conversation

@Maya-Kid

Copy link
Copy Markdown

An image with no entrypoint or command could fail with “give args” and stay failed even after the operator retried the same name and image with explicit arguments. Pending templates now accept a nonempty args override. The attempt update and old pull report reset commit in the same transaction, so the new attempt uses the corrected command.

The HTTP integration test follows the template from failed to ready, rejects the stale attempt report, and verifies the corrected command reaches sandbox creation with the original environment, memory, and port. It also checks that retrying an already-ready template keeps its existing configuration.

All 408 Rust tests passed on macOS, including the master API suite. Clippy, formatting, and diff checks passed.

Signed-off-by: dada-yan <BinjunYann@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant