Repository navigation
Conversation
Signed-off-by: dada-yan <BinjunYann@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An image with no entrypoint or command could fail with “give args” and stay failed even after the operator retried the same name and image with explicit arguments. Pending templates now accept a nonempty args override. The attempt update and old pull report reset commit in the same transaction, so the new attempt uses the corrected command.
The HTTP integration test follows the template from failed to ready, rejects the stale attempt report, and verifies the corrected command reaches sandbox creation with the original environment, memory, and port. It also checks that retrying an already-ready template keeps its existing configuration.
All 408 Rust tests passed on macOS, including the master API suite. Clippy, formatting, and diff checks passed.