Repository navigation
Conversation
Signed-off-by: dada-yan <BinjunYann@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fleet.sh could report success when the master rejected a template registration or failed to delete the verification sandbox. Check the HTTP status for each master request and report non-2xx replies with the method, path, and response detail. The helper uses curl's existing status write-out support.
A rejected template registration now fails seed. Verification still attempts cleanup if the status lookup fails, and a failed cleanup exits nonzero and prints the probe sandbox ID.
Add six CLI regression tests to CI. They run real curl against a loopback server with SSH stubbed out and cover HTTP 409 on registration, HTTP 500 on cleanup or status, creation refusal, and the successful seed and verify paths. All six tests passed locally, along with bash syntax and diff checks.