Skip to content

fix(mcp): find progress markers outside the log excerpt - #455

Open
Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/mcp-log-markers
Open

Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/mcp-log-markers

Conversation

@Maya-Kid

Copy link
Copy Markdown

wait_for_text only searched the final 4 KiB, so a progress marker could become invisible after more log output. Search the guest file for the literal marker and return its match status separately from the 256-byte diagnostic tail.

Pass the file path and marker as separate arguments so paths containing spaces work. Treat a file that has not appeared yet as a miss and keep polling. Multiline markers continue to match as a single literal substring.

The regression tests exercise the guest command against local files through a mock master. They cover markers before the excerpt, space-containing paths, literal and multiline matching, and a log that appears during polling. Both MCP CI dependency configurations passed all 47 tests locally. Ruff and diff checks passed.

Signed-off-by: dada-yan <BinjunYann@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant