fix: prevent N×M reply explosion in HuggingFaceLocalGenerator with multiple stop_words

[NIK-TIGER-BILL]

Related Issues

• fixes bug: HuggingFaceLocalGenerator returns N×M replies instead of N when stop_words has multiple entries #11409

Proposed Changes:

The list comprehension in HuggingFaceLocalGenerator.run() used two for clauses to remove stop words from replies:

replies = [reply.replace(stop_word, "").rstrip() for reply in replies for stop_word in self.stop_words]

This creates a cross-product: with N replies and M stop words the output contains N×M replies instead of N. Half of the extra replies still contain the stop word, and downstream components receive an unexpected number of replies.

The fix replaces the comprehension with an explicit outer loop over stop_words, matching the already-correct implementation in HuggingFaceChatLocalGenerator (chat/hugging_face_local.py, line 654):

for stop_word in self.stop_words:
    replies = [reply.replace(stop_word, "").rstrip() for reply in replies]

How did you test it?

• Added a new unit test test_run_multiple_stop_words_removal that mocks a pipeline returning 2 replies with 2 stop words configured.
• Before the fix the test would produce 4 replies; after the fix it correctly returns 2 replies with both stop words stripped.
• Verified the exact logic with a standalone Python snippet.

Notes for the reviewer

This is a minimal, surgical change. The sibling chat generator already uses the same sequential approach, so this only brings the non-chat generator in line with the existing pattern.

Checklist

• I have read the contributors guidelines and the code of conduct.
• I have updated the related issue with new insights and changes.
• I have added unit tests and updated the docstrings.
• I have used one of the conventional commit types for my PR title: fix: ....
• I have documented my code.
• I have added a release note file, following the contributors guidelines.
• I have run pre-commit hooks and fixed any issue.

This PR was fully generated with an AI assistant. I have reviewed the changes and run the relevant tests.

[vercel]

Someone is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

[CLAassistant]

All committers have signed the CLA.

[julian-risch]

@NIK-TIGER-BILL Thank you for opening this pull request. Would you please agree to our CLA? Otherwise we can't merge this pull request. #11413 (comment)

[NIK-TIGER-BILL]

@NIK-TIGER-BILL Thank you for opening this pull request. Would you please agree to our CLA? Otherwise we can't merge this pull request. #11413 (comment)

Done!
https://cla-assistant.io/deepset-ai/haystack - "You have agreed to the CLA for deepset-ai/haystack"

[julian-risch]

@NIK-TIGER-BILL Your commit in this pull request appears not to be linked to your user account. Could you please fix that? Here are instructions: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

[NIK-TIGER-BILL]

@julian-risch The commit author is already set to NIK-TIGER-BILL <nik.tiger.bill@github.com>. Could the issue be that this email address needs to be verified in my GitHub account settings? I have amended the commits with this email previously. Please let me know if there is anything else I should adjust.

[julian-risch]

@NIK-TIGER-BILL Unfortunately, the problem with the CLA is not solved yet in this PR. What you did in this other PR #11385 solved the problem there. Did you force push already?

git config user.email "new.email@example.com"
git commit --amend --author="Your Name <new.email@example.com>" --no-edit
git push --force-with-lease

[NIK-TIGER-BILL]

@julian-risch Done — I rebased the branch on latest main, kept the original fix, and force-pushed. The commit author is set to NIK-TIGER-BILL <nik.tiger.bill@github.com>. Let me know if the CLA check passes now.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
haystack-docs	Ignored	Preview	Jun 5, 2026 2:00pm