fix: In AsyncPipeline cancel inflight tasks if a PipelineRuntimeError is raised by another component#11499
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
topic:tests
topic:core
type:documentation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
anakin87
requested changes
Jun 3, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thank you. I left two comments.
Was wondering since we are leaning towards merging the two classes if it would be possible to also bring concurrency to Pipeline.run.
I would support this if feasible. Concurrency!=async and this would make things clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Fixes an issue that any inflight tasks would leak if a component raised an error in
AsyncPipelinewith concurrency > 1How did you test it?
Added new unit test
Notes for the reviewer
Found this while investigating merging
PipelineandAsyncPipeline. Was wondering since we are leaning towards merging the two classes if it would be possible to also bring concurrency toPipeline.run. This is somewhat complicated by theBreakPointfeature though since the creation of aPipelineSnaphsotis only valid if there are no in-flight tasks.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.