fix(device): Device.from_str crashes on a multi-colon device string#11519
Closed
devteamaegis wants to merge 1 commit into
Closed
fix(device): Device.from_str crashes on a multi-colon device string#11519devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
Ishaan Samantray seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
|
This same PR was already closed here #11452 with the reasoning provided here #11452 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
_split_device_stringunpacksstring.split(":")into exactly two variables with nomaxsplit. A device string with a second colon raises an uncaught error through the publicDevice.from_str:Why it happens
str.split(":")withoutmaxsplit=1returns more than two parts when the string has more than one colon.Fix
Use
split(":", maxsplit=1)."cuda:0:1"then splits to("cuda", "0:1");int("0:1")fails and raises the function's existing, descriptiveValueError("Device id must be an integer, got 0:1")instead of the opaque unpack error.Test
Added a case asserting
Device.from_str("cuda:0:1")raisesValueErrorabout the device id;"cuda:0"and"cpu"still parse correctly.Fixes #11518