docs(funasr): add FunASRTranscriber component page#11520
Conversation
|
@SyedShahmeerAli12 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
julian-risch
left a comment
There was a problem hiding this comment.
@SyedShahmeerAli12 Thank you so much for opening this PR as a follow up to the code changes in haystack-core-integrations. Much appreciated!
I have some smaller change requests:
-
import path must use
audionotconverters based on the change described here https://github.com/deepset-ai/haystack-core-integrations/pull/3376#pullrequestreview-4429629881from haystack_integrations.components.audio.funasr import FunASRTranscriber`
Both the "On its own" and "In a pipeline" examples need fixing (and both files: the live doc and the version-2.x mirror). Given that we released 2.30 this week, it makes more sense to apply changes to version-2.30 and not to 2.28 please. -
The "GitHub link" row points to .../components/converters/funasr/transcriber.py
but correct path is .../components/audio/funasr/transcriber.py.
Once these two points are addressed, I am happy to approve and merge.
Sorry for the oversight the converters ... audio rename was pushed by @anakin87 as a final change after the PR was merged, so our docs were already pointing to the old path by the time I opened this PR. Fixed in the latest commit import paths and GitHub link now use components/audio/funasr, and the versioned mirror has been moved from version-2.28 to version-2.30. |
julian-risch
left a comment
There was a problem hiding this comment.
Thanks for addressing the change requests so quickly! 👍 And no worries, all good. 👍
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Related Issues
deepset-ai/haystack-core-integrations#3375
Proposed Changes
docs-website/docs/pipeline-components/audio/funasrtranscriber.mdxdocs-website/docs/pipeline-components/audio.mdxdocs-website/sidebars.jswith the new page entryversioned_docs/version-2.30How did you test it?
Followed the same structure as the existing
localwhispertranscriber.mdxpage andbravewebsearch.mdx(PR #11269).Notes for the reviewer
This is the docs PR for the FunASR integration, which is already merged in
haystack-core-integrations. The companion integration tile PR is at deepset-ai/haystack-integrations#496.Checklist