Skip to content

docs(funasr): add FunASRTranscriber component page#11520

Merged
julian-risch merged 2 commits into
deepset-ai:mainfrom
SyedShahmeerAli12:docs/funasr-transcriber
Jun 5, 2026
Merged

docs(funasr): add FunASRTranscriber component page#11520
julian-risch merged 2 commits into
deepset-ai:mainfrom
SyedShahmeerAli12:docs/funasr-transcriber

Conversation

@SyedShahmeerAli12
Copy link
Copy Markdown
Contributor

@SyedShahmeerAli12 SyedShahmeerAli12 commented Jun 4, 2026

Related Issues

deepset-ai/haystack-core-integrations#3375

Proposed Changes

  • New page: docs-website/docs/pipeline-components/audio/funasrtranscriber.mdx
  • Added FunASRTranscriber row to docs-website/docs/pipeline-components/audio.mdx
  • Updated docs-website/sidebars.js with the new page entry
  • Mirrored all changes in versioned_docs/version-2.30

How did you test it?

Followed the same structure as the existing localwhispertranscriber.mdx page and bravewebsearch.mdx (PR #11269).

Notes for the reviewer

This is the docs PR for the FunASR integration, which is already merged in haystack-core-integrations. The companion integration tile PR is at deepset-ai/haystack-integrations#496.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have updated the documentation if needed

@SyedShahmeerAli12 SyedShahmeerAli12 requested a review from a team as a code owner June 4, 2026 18:54
@SyedShahmeerAli12 SyedShahmeerAli12 requested review from julian-risch and removed request for a team June 4, 2026 18:54
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

@SyedShahmeerAli12 is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyedShahmeerAli12 Thank you so much for opening this PR as a follow up to the code changes in haystack-core-integrations. Much appreciated!
I have some smaller change requests:

  1. import path must use audio not converters based on the change described here https://github.com/deepset-ai/haystack-core-integrations/pull/3376#pullrequestreview-4429629881 from haystack_integrations.components.audio.funasr import FunASRTranscriber`
    Both the "On its own" and "In a pipeline" examples need fixing (and both files: the live doc and the version-2.x mirror). Given that we released 2.30 this week, it makes more sense to apply changes to version-2.30 and not to 2.28 please.

  2. The "GitHub link" row points to .../components/converters/funasr/transcriber.py
    but correct path is .../components/audio/funasr/transcriber.py.

Once these two points are addressed, I am happy to approve and merge.

@SyedShahmeerAli12
Copy link
Copy Markdown
Contributor Author

SyedShahmeerAli12 commented Jun 5, 2026

@SyedShahmeerAli12 Thank you so much for opening this PR as a follow up to the code changes in haystack-core-integrations. Much appreciated! I have some smaller change requests:

  1. import path must use audio not converters based on the change described here https://github.com/deepset-ai/haystack-core-integrations/pull/3376#pullrequestreview-4429629881 from haystack_integrations.components.audio.funasr import FunASRTranscriber`
    Both the "On its own" and "In a pipeline" examples need fixing (and both files: the live doc and the version-2.x mirror). Given that we released 2.30 this week, it makes more sense to apply changes to version-2.30 and not to 2.28 please.
  2. The "GitHub link" row points to .../components/converters/funasr/transcriber.py
    but correct path is .../components/audio/funasr/transcriber.py.

Once these two points are addressed, I am happy to approve and merge.

Sorry for the oversight the converters ... audio rename was pushed by @anakin87 as a final change after the PR was merged, so our docs were already pointing to the old path by the time I opened this PR. Fixed in the latest commit import paths and GitHub link now use components/audio/funasr, and the versioned mirror has been moved from version-2.28 to version-2.30.

Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the change requests so quickly! 👍 And no worries, all good. 👍

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jun 5, 2026 10:29am

Request Review

@julian-risch julian-risch merged commit 368729f into deepset-ai:main Jun 5, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants