Repository navigation
Revert #29 - #34
Merged
Merged
Revert #29#34
Conversation
sini
reviewed
Oct 18, 2026
sini
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Using the same override logic inside and outside the outputs function is cleaner, and the inherit (… from.flake inputs.home-manager {}) nixpkgs idiom covers the #26 case. topLevelInputs and nonEmptyInputs were indeed unused. just ci passes (51/51), and so does this branch merged with #32 and #33 (52/52).
Nits:
- Typo inline.
- Worth a test for the documented
inheritidiom, so the #26 case stays covered now that #29's reproducer is gone. - The removed "Flake backed by non-flake pins" section was inaccurate, but the mechanism it was describing still exists:
indirect, built frombuiltins.functionArgs flake.outputs. Maybe give it a one-line mention so it isn't undocumented.
Contributor
Author
fixed.
I'll add the test in #33.
the AI got confused here, the obsolete removed section had nothing to do with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#29 was merged following a regression I noticed, but I now think it was due to me wrongly the api, hence the revert.
Indeed the idiom of returning another input as the outputs
nixpkgs = with-inputs.from.flake inputs.home-manager { } (i: i.nixpkgs)is much better written:inherit (with-inputs.from.flake inputs.home-manager {}) nixpkgs;So reverting #29 in order to keep the same override logic inside and outside the "outputs" function, which is much cleaner imo.
Added doc to document this.