Repository navigation
fix: refuse a follows cycle among overrides by name instead of overflowing the stack - #38
Merged
Merged
Conversation
…owing the stack Two overrides that follow each other, with neither chain reaching the input being built, made recFollows recurse until the stack overflowed. The walk now carries the inputs already on its chain and throws "with-inputs: follows cycle: a -> b -> a". Reported in Matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #35. In
mkDefaultWithInputsInput,recFollowswalksfollowschains among the overrides. When two overrides follow each other and neither chain reaches the input being built, the walk never ends:The walk now carries the inputs already on its chain. When it meets one of them again it throws by name:
Chains that reach the input, or that stop at a root that isn't an override (#35), behave as before.
Validation
nix-unit ./tests.nix: 55/55, including the newinput-overrides.test-follows-cycle-is-refused, which expects aThrownErrormatchingfollows cycle.with-inputs.nixreverted, the suite fails withstack overflow (possible infinite recursion), so the test catches the bug.treefmt --ci: 0 files changed.just loaders.