Repository navigation
fix(api): stop the intermittent nestjs async-module require failure in tests - #1384
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision #98.
apps/apispecs intermittently failed withrequire() async module "@nestjs/core" is unsupportedwhile@nestjs/throttlerloaded (reruns on #1366, #1373, #1378).Root cause: a Bun module-loader race, oven-sh/bun#33180 (regressed in 1.3.14; the fix, oven-sh/bun#37185, is still open).
@nestjs/throttleris CJS andrequire()s@nestjs/common/@nestjs/corefrom its module body while the ESM graph is still fetching them. Arequire()that lands on an entry withFetchingstatus is misreported as an async module. Ruled out:@nestjs/*graph;bunimporting the same graph: clean, 0/60.Fix:
apps/api/nestjs-preload.ts, loaded first inbunfig.toml, imports both packages before any spec loads, so throttler'srequire()takes the synchronous path.sandbox-checkpoint-write)BUN_TEST_INCREMENTAL=1apps/apisuiteTest-only: nothing in the shipped app changes.