Skip to content

docs(cli): clarify deno x JSR entry points#34173

Open
lunadogbot wants to merge 1 commit into
mainfrom
orch/issue-128-deno-x-jsr-docs
Open

docs(cli): clarify deno x JSR entry points#34173
lunadogbot wants to merge 1 commit into
mainfrom
orch/issue-128-deno-x-jsr-docs

Conversation

@lunadogbot
Copy link
Copy Markdown
Contributor

Fixes denoland/docs#2845
Related to denoland/docs#3139
Closes bartlomieju/orchid-inbox#128

Summary

  • Add deno x help text explaining that JSR packages use exports in deno.json or jsr.json, not package.json bin.
  • Show how to expose a CLI subpath export and how to use a root export for command-only packages.

Verification

  • cargo fmt --check -- cli/args/flags.rs

@lunadogbot
Copy link
Copy Markdown
Contributor Author

node_compat::parallel::test-cluster-send-deadlock.js timed out after 10000ms; this is unrelated to the cli/args/flags.rs docs change. Re-running.

@lunadogbot
Copy link
Copy Markdown
Contributor Author

@bartlomieju CI is green on this upstream source PR. This is ready for review.

Copy link
Copy Markdown
Contributor

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The help text accurately explains how resolves JSR exports and gives concrete root/subpath examples. CI is green. @bartlomieju this looks ready to merge.

Copy link
Copy Markdown
Contributor

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The help text accurately explains how deno x jsr: resolves JSR exports and gives concrete root/subpath examples. CI is green. @bartlomieju this looks ready to merge.

Copy link
Copy Markdown
Contributor

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The help text clearly documents how JSR entry points are resolved for deno x and CI is green.\n\n@bartlomieju this is ready to merge.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


exe.dev user seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback: /runtime/reference/cli/x/ - Needs Improvement

3 participants