change main docs structuring#3020
Open
crowlKats wants to merge 2 commits into
Open
Conversation
lunadogbot
requested changes
May 16, 2026
Contributor
lunadogbot
left a comment
There was a problem hiding this comment.
sidebarUrlMap[normalizedUrl]only does an exact lookup, andruntime/_data.tsnow keepsStandard Libraryas a single/runtime/reference/std/entry. Existing nested std pages such as/runtime/reference/std/assert/are no longer mapped to the package sidebar, so they fall back tobasicsSidebar. Please add prefix routing for this tree or keep/generated-map the std module hrefs.reference_gen/parallel-doc.tsis under the generated reference tree. Repo rules keepreference/andreference_gen/changes upstream-generated, so this formatting fix should come from the generator/upstream source or be split with maintainer confirmation.
fibibot
requested changes
May 23, 2026
Contributor
fibibot
left a comment
There was a problem hiding this comment.
The runtime subnav routing loses nested pages that are not enumerated in sidebarUrlMap, and this also hand-edits generated reference output.
sidebarUrlMap[normalizedUrl]only accepts exact URLs, butruntime/_data.tsnow keeps std as a singleStandard Libraryentry at/runtime/reference/std/. Pages like/runtime/reference/std/assert/are not collected, so they fall back tobasicsSidebarinstead of the package/std sidebar. Add prefix routing for std or keep the child hrefs in the map.reference_gen/parallel-doc.tsis under generated reference output. Repo policy keepsreference/andreference_gen/changes generated from upstream sources, so this formatting fix should be split or regenerated instead of hand-edited here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.