Repository navigation
Conversation
Dependency review rejected robust-predicates (Unlicense and public domain) and uri-js (BSD-2-Clause with BSD-2-Clause-Views), both pulled in by the documentation site and both compatible with distributing GrantForge under MIT.
A pushed tag v<version> now builds the distribution, a CycloneDX SBOM of what it ships and their checksums with script/ci/release.sh, takes the notes from the version's changelog page, pushes a multi-arch image to GHCR and creates the GitHub release; -rc.N versions are pre-releases. check_versions.py keeps the version equal in every pom, package, the Helm chart, the console and the README, and changes them all with --set. The chart defaults to the published image.
Packaging builds the console with pnpm, which the nightly image smoke tests and the release job did not install, so every smoke test failed before it started.
gitleaks flagged the Base32 TOTP key in TotpCodesTest, which is the public test vector of RFC 6238 and no secret. A .gitleaksignore keeps that one fingerprint, with its reason, so the full-history scan passes without loosening any rule.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| distribution: temurin | ||
| java-version: '21' | ||
| cache: maven | ||
| - uses: pnpm/action-setup@v4 |
| distribution: temurin | ||
| java-version: '21' | ||
| cache: maven | ||
| - uses: pnpm/action-setup@v4 |
| version="${GITHUB_REF_NAME#v}" | ||
| echo "version=${version}" >> "${GITHUB_OUTPUT}" | ||
| if [[ "${version}" == *-rc.* ]]; then echo "prerelease=true" >> "${GITHUB_OUTPUT}"; else echo "prerelease=false" >> "${GITHUB_OUTPUT}"; fi | ||
| - uses: docker/setup-qemu-action@v3 |
| echo "version=${version}" >> "${GITHUB_OUTPUT}" | ||
| if [[ "${version}" == *-rc.* ]]; then echo "prerelease=true" >> "${GITHUB_OUTPUT}"; else echo "prerelease=false" >> "${GITHUB_OUTPUT}"; fi | ||
| - uses: docker/setup-qemu-action@v3 | ||
| - uses: docker/setup-buildx-action@v3 |
| if [[ "${version}" == *-rc.* ]]; then echo "prerelease=true" >> "${GITHUB_OUTPUT}"; else echo "prerelease=false" >> "${GITHUB_OUTPUT}"; fi | ||
| - uses: docker/setup-qemu-action@v3 | ||
| - uses: docker/setup-buildx-action@v3 | ||
| - uses: docker/login-action@v3 |
The image smoke test asked Maven for the mysql.version property, which the imported Spring Boot BOM does not expose, so it fetched mysql-connector-j:null and the MySQL run failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one)
Changelog entry (Details of this change)
Affected version