Skip to content

fix: initialize default SSO URL before saving - #3121

Open
sagarkt wants to merge 1 commit into
devtron-labs:developfrom
sagarkt:ao/devtron-65/fix-sso-default-url
Open

fix: initialize default SSO URL before saving#3121
sagarkt wants to merge 1 commit into
devtron-labs:developfrom
sagarkt:ao/devtron-65/fix-sso-default-url

Conversation

@sagarkt

@sagarkt sagarkt commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • initialize new and legacy-empty SSO configurations with the current orchestrator URL
  • keep the URL shown in the form synchronized with the state validated by Save
  • clear the required-field error when the suggested URL is selected

Problem

The SSO form historically rendered the orchestrator URL as a fallback while leaving ssoConfig.url empty. Save validates ssoConfig.url, so an apparently populated form failed with "Some required field are missing" until the user clicked the suggested URL. The YAML editor's inner connector config was not the missing field.

Testing

  • git diff --check
  • Reviewed both default-empty and previously saved custom URL paths
  • Full TypeScript/ESLint checks could not complete locally because Yarn stalled while linking the dependency tree; PR CI should run the canonical checks

Fixes devtron-labs/devtron#6312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: SSO Login Service configuration is misaligned and prevents saving

1 participant