Skip to content

chore: flag to dynamically access audit logs #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivani170 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: flag to dynamically access audit logs #3125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Navigation/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,9 @@
],
isAvailableInEA: true,
},
...(SDH_NAV_GROUP ? [SDH_NAV_GROUP] : []),

Check failure on line 208 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type '{ id: "audit-logs"; title: string; icon: "ic-file-log-search"; href: string; forceHideEnvKey: "ENABLE_AUDIT_LOG"; }' is not assignable to type 'NavigationGroupType'.
...(COST_VISIBILITY_NAV_GROUP ? [COST_VISIBILITY_NAV_GROUP] : []),

Check failure on line 209 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type 'NavigationGroupType | { id: "security-center"; title: string; icon: "ic-shield-check"; items: NavigationItemType[]; } | { id: "automation-and-enablement"; title: string; icon: "ic-bot"; items: { ...; }[]; } | { ...; } | { ...; }' is not assignable to type 'NavigationGroupType'.
{

Check failure on line 210 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type 'NavigationGroupType | { id: "security-center"; title: string; icon: "ic-shield-check"; items: NavigationItemType[]; } | { id: "automation-and-enablement"; title: string; icon: "ic-bot"; items: { ...; }[]; } | { ...; } | { ...; }' is not assignable to type 'NavigationGroupType'.
id: 'security-center',
title: 'Security Center',
icon: 'ic-shield-check',
Expand Down Expand Up @@ -236,7 +236,7 @@
},
],
},
{

Check failure on line 239 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type 'NavigationGroupType | { id: "security-center"; title: string; icon: "ic-shield-check"; items: NavigationItemType[]; } | { id: "automation-and-enablement"; title: string; icon: "ic-bot"; items: { ...; }[]; } | { ...; } | { ...; }' is not assignable to type 'NavigationGroupType'.
id: 'automation-and-enablement',
title: 'Automation & Enablement',
icon: 'ic-bot',
Expand All @@ -250,8 +250,8 @@
},
],
},
...(DATA_PROTECTION_MANAGEMENT_NAV_GROUP ? [DATA_PROTECTION_MANAGEMENT_NAV_GROUP] : []),

Check failure on line 253 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type 'NavigationGroupType | { id: "security-center"; title: string; icon: "ic-shield-check"; items: NavigationItemType[]; } | { id: "automation-and-enablement"; title: string; icon: "ic-bot"; items: { ...; }[]; } | { ...; } | { ...; }' is not assignable to type 'NavigationGroupType'.
{

Check failure on line 254 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type 'NavigationGroupType | { id: "security-center"; title: string; icon: "ic-shield-check"; items: NavigationItemType[]; } | { id: "automation-and-enablement"; title: string; icon: "ic-bot"; items: { ...; }[]; } | { ...; } | { ...; }' is not assignable to type 'NavigationGroupType'.
id: 'global-configuration',
title: 'Global Configuration',
icon: 'ic-gear',
Expand Down Expand Up @@ -327,6 +327,7 @@
title: 'Audit logs',
icon: 'ic-file-log-search',
href: `${ROUTER_URLS.AUDIT_LOGS}?sortBy=timeStamp&sortOrder=DESC`,
forceHideEnvKey: 'ENABLE_AUDIT_LOG',

Check failure on line 330 in src/components/Navigation/constants.ts

View workflow job for this annotation

GitHub Actions / ci 

Type '"ENABLE_AUDIT_LOG"' is not assignable to type 'keyof customEnv'.
},
]

Expand Down
16 changes: 9 additions & 7 deletions src/components/common/navigation/NavigationRoutes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,13 +566,15 @@
path={`${BASE_ROUTES.INFRASTRUCTURE_MANAGEMENT.ROOT}/*`}
element={<InfrastructureManagementRouter isSuperAdmin={isSuperAdmin} />}
/>
{serverMode === SERVER_MODE.FULL && AuditLogsRouter && (
<Route
key={BASE_ROUTES.AUDIT_LOGS.ROOT}
path={`${BASE_ROUTES.AUDIT_LOGS.ROOT}/*`}
element={<AuditLogsRouter />}
/>
)}
{serverMode === SERVER_MODE.FULL &&
window._env_.ENABLE_AUDIT_LOG &&

Check failure on line 570 in src/components/common/navigation/NavigationRoutes.tsx

View workflow job for this annotation

GitHub Actions / ci 

Property 'ENABLE_AUDIT_LOG' does not exist on type 'customEnv'.
AuditLogsRouter && (
<Route
key={BASE_ROUTES.AUDIT_LOGS.ROOT}
path={`${BASE_ROUTES.AUDIT_LOGS.ROOT}/*`}
element={<AuditLogsRouter />}
/>
)}
{!window._env_.K8S_CLIENT
? [
...(serverMode === SERVER_MODE.FULL
Expand Down
1 change: 1 addition & 0 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@
HIDE_NETWORK_STATUS_INTERFACE: true,
SYSTEM_CONTROLLER_LISTING_TIMEOUT: 60000 * 5,
FEATURE_IMAGE_PROMOTION_ENABLE: true,
ENABLE_AUDIT_LOG: false,

Check failure on line 157 in src/index.tsx

View workflow job for this annotation

GitHub Actions / ci 

Object literal may only specify known properties, and 'ENABLE_AUDIT_LOG' does not exist in type 'customEnv'.
FEATURE_HIDE_USER_DIRECT_PERMISSIONS_FOR_NON_SUPER_ADMINS: false,
FEATURE_CONFIG_DRIFT_ENABLE: true,
FEATURE_PROMO_EMBEDDED_BUTTON_TEXT: '',
Expand Down
2 changes: 1 addition & 1 deletion vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { VitePWA } from 'vite-plugin-pwa'
import { compression, defineAlgorithm } from 'vite-plugin-compression2'

const WRONG_CODE = `import { bpfrpt_proptype_WindowScroller } from "../WindowScroller.js";`
const TARGET_URL = 'https://preview.devtron.ai/'
const TARGET_URL = 'https://devtron-ent-5.devtron.info/'

function reactVirtualized(): PluginOption {
return {
Expand Down
Loading