server: enable IPv6 LAN discovery - #1315
Open
HashimTheArab wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Blocked on Sandertv/gophertunnel#465. The temporary |
The server already fans in multiple listeners, so the multiListener wrapper is unnecessary. listenerFunc is now parameterized by address and both listeners share one gophertunnel ListenerGroup. A failed IPv6 bind now logs an error and leaves the IPv4 listener running instead of failing both.
RestartFU
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[::]:19133by default alongside the IPv4 listener on:19132, using the server's existing multi-listener support (oneConfig.Listenersentry per address)Network.AddressV6ListenerGroup(minecraft: share player state between listeners Sandertv/gophertunnel#465)conf.Newpreviously appended a nil listener when a listener factory errored — fixed withcontinue)PocketMine documents UDP 19133 as the IPv6 port used by Bedrock LAN discovery: https://github.com/pmmp/PocketMine-MP/blob/stable/changelogs/4.0.md#general
Note: the
go.mod/go.sumchurn comes from a temporaryreplacepointing at my gophertunnel fork with theListenerGroupsupport; it will be dropped once gophertunnel tags a release including Sandertv/gophertunnel#465.Validation
go test ./...git diff --check