Implement tridents - #1342
Open
Superomarking wants to merge 7 commits into
Open
Conversation
RestartFU
reviewed
Jul 22, 2026
RestartFU
left a comment
RestartFU
left a comment
Collaborator
There was a problem hiding this comment.
Inline findings attached.
| } | ||
| if conf.Item.Empty() { | ||
| conf.Item = item.NewStack(item.Trident{}, 1) | ||
| } |
Collaborator
There was a problem hiding this comment.
[P1] Persisted tridents are rebuilt without Owner or the returning state, so a chunk unload/restart breaks Loyalty; a stuck loyalty trident then reaches b.conf.Owner.Entity(...) with a nil handle and panics, while a returning one no longer returns. Persist a resolvable owner/return state and make the owner lookups nil-safe.
Contributor
Author
There was a problem hiding this comment.
If anyone could help me with this would be appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fully implement tridents, needs testing.