Repository navigation
refactor(loading): use the shared Spinner for every loader icon - #465
Merged
Merged
Conversation
Replace the raw `Loader2` and `Loader` icons with the shared `Spinner`. Replace the two processing halos with one `ProcessingSpinner`.
|
✅ No security or compliance issues detected. Reviewed everything up to b892471. Security OverviewDetected Code Changes
|
📊 Build Bundle StatsThe latest build generated the following assets: |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Raw loader icons remain in two loading states despite the PR’s stated complete migration.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Standardizes loading indicators around shared spinner components.
Changes:
- Replaces inline Lucide loaders with
Spinner. - Adds
ProcessingSpinnerfor mutation and staking processing states. - Removes duplicated animated loader helpers.
| File | Description |
|---|---|
KnownNeuronCard.tsx |
Uses shared spinner while loading. |
AdvancedFollowingModal.tsx |
Standardizes certification loading icon. |
StakingWizardStepConfirmation.tsx |
Uses the processing spinner. |
NeuronDetailMaturityModeView.tsx |
Standardizes pending indicator. |
NeuronDetailIncreaseStakeView.tsx |
Standardizes pending indicator. |
NeuronDetailIncreaseDelayView.tsx |
Standardizes pending indicator. |
NeuronDetailDissolveView.tsx |
Standardizes pending indicator. |
FollowingStatusAlert.tsx |
Standardizes processing indicator. |
ProposalListItem.tsx |
Standardizes vote loaders. |
ProposalDetailsVoting.tsx |
Standardizes vote loaders. |
ProcessingSpinner.tsx |
Introduces the shared processing halo. |
MutationDialog.tsx |
Replaces its local animated spinner. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yhabib
changed the title
Hide both from screen readers. The toast is already a live region, and visible text names the welcome detection wait.
yhabib
changed the title
daniel-wong-dfinity-org-twin
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The app drew its spinners three ways: raw
Loader2icons, rawLoadericons, and two custom processing halos. Split from #447.Changes
Loader2andLoadericons to the sharedSpinner.ProcessingSpinnerand used it inMutationDialogand the staking wizard.AnimatedSpinnerandAnimatedLoaderhelpers.