Repository navigation
Allow arbitrary MCP hostname - #223
Merged
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 8b09809. Security Overview
Detected Code Changes
|
There was a problem hiding this comment.
Pull request overview
Routes MCP requests before domain resolution, allowing MCP to use arbitrary hostnames.
Changes:
- Adds hostname-based MCP middleware.
- Updates arbitrary-hostname integration coverage.
- Adds custom Internet Identity configuration parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/routing/mod.rs |
Installs early MCP routing and updates tests. |
src/mcp.rs |
Adds MCP middleware, state, and custom II parsing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
frankdavid
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if MCP hostname does not overlap with any of base/custom domains - it doesn't work due to the base domain lookup failure.
This PR fixes it by reworking how MCP calls are handled: they're caught now early on and passed directly to the MCP router before any other middleware kicks in.