chore: DEFI-2304 remove deprecated ic-cdk imports in icp-ledger#10320
Draft
gregorydemay wants to merge 2 commits into
Draft
chore: DEFI-2304 remove deprecated ic-cdk imports in icp-ledger#10320gregorydemay wants to merge 2 commits into
gregorydemay wants to merge 2 commits into
Conversation
Migrate the ICP ledger canister off `ic_cdk::api::call::{arg_data_raw, reply, reply_raw}`,
`ic_cdk::api::{caller, print, set_certified_data, stable::StableReader, stable::stable_size}`
(all deprecated in #6264), and drop the file-level `#![allow(deprecated)]`. Imports use
`as` aliases so the existing identifier-based call sites are preserved, which keeps the
diff focused on the import line. The single `reply((result,))` site is rewritten as
`reply_raw(Encode!(&result).unwrap())` to preserve the on-wire Candid output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the ICP ledger canister off deprecated ic-cdk APIs introduced under #![allow(deprecated)] in #6264, replacing them with their non-deprecated counterparts via as aliases to keep call sites unchanged.
Changes:
- Replaces deprecated
ic_cdk::api::{call::{arg_data_raw, reply_raw}, caller, print, set_certified_data}withmsg_arg_data,msg_reply,msg_caller,debug_print,certified_data_set(aliased to old names). - Migrates
ic_cdk::api::stable::{StableReader, stable_size}toic_cdk::stable::*. - Rewrites the single Candid
reply((result,))site inget_nodesasreply_raw(Encode!(&result).unwrap()).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends DEFI-2304 — removing the file-level
#![allow(deprecated)]attribute introduced in #6264.This PR handles
icp-ledger:ic_cdk::api::call::{arg_data_raw, reply, reply_raw}→ic_cdk::api::{msg_arg_data, msg_reply}.ic_cdk::api::caller→ic_cdk::api::msg_caller.ic_cdk::api::print→ic_cdk::api::debug_print.ic_cdk::api::set_certified_data→ic_cdk::api::certified_data_set.ic_cdk::api::stable::StableReader→ic_cdk::stable::StableReader.ic_cdk::api::stable::stable_size→ic_cdk::stable::stable_size.Imports use
asaliases so the existing identifier-based call sites (caller(),arg_data_raw(),reply_raw(&res),print(...)) are preserved — that keeps the diff focused on the import line. The single fully qualifiedic_cdk::api::call::reply((result,))site is rewritten asreply_raw(Encode!(&result).unwrap())to preserve the on-wire Candid output. No behavior change.Follows the pattern set by #6755 (
ic-btc-checker), #6761 (ic-ckbtc-minter), #10289, #10290, #10291, #10317, #10318 and #10319.