feat: wip, build determinism issues#10349
Draft
nmattia wants to merge 48 commits into
Draft
Conversation
The patch was redundant — crate_universe derives crate features from the lock file, so removing wasm32_unknown_unknown_js from ring-0.17.14's wasm32 feature selects in Cargo.Bazel.json.lock is the only fix needed. The patch was also breaking ring-0.16.20 builds since it only applied to 0.17.x Cargo.toml layout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The patch_args and patches fields were still baked into ring 0.16.20 and 0.17.14 repository entries in Cargo.Bazel.json.lock even after deleting bazel/ring.patch, causing "Cannot find patch file" errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rustls 0.23 requires CryptoProvider::install_default() before any TLS usage. The canister http adapter uses hyper-rustls which calls into rustls without a provider, causing it to panic and time out on startup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.