perf: Directly serialize signed bytes into Vec holding domain separator#10351
Queued
eichhorl wants to merge 4 commits into
Queued
perf: Directly serialize signed bytes into Vec holding domain separator#10351eichhorl wants to merge 4 commits into
Vec holding domain separator#10351eichhorl wants to merge 4 commits into
Conversation
eichhorl
changed the title
Vec holding domain separator
alin-at-dfinity
approved these changes
Jun 1, 2026
Contributor
alin-at-dfinity
left a comment
alin-at-dfinity
left a comment
There was a problem hiding this comment.
Very nice, thank you!
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are two kinds of messages that are signed by the replica:
In both cases, the function
as_signed_bytes_without_domain_separatorcurrently produces a newly owned vec (a fresh serialization for 1. and a clone for 2.), which is then appended onto a different vector holding the domain prefix.Instead, this PR replaces
fn as_signed_bytes_without_domain_separator(&self) -> Vec<u8>withfn write_signed_bytes_without_domain_separator(&self, bytes: &mut Vec<u8>)which appends/serializes the message bytes directly into the buffer that already holds the domain separator. This saves one clone/allocation of the data to be signed/verified in both cases.Additionally we remove a few other unnecessary allocations.