Skip to content

build: update pinned ci-tools to a98f5d0 - #1404

Merged
marc0olo merged 1 commit into
mainfrom
build/ci-tools-a98f5d0
Sep 25, 2026
Merged

marc0olo merged 1 commit into
mainfrom
build/ci-tools-a98f5d0

Conversation

@marc0olo

Copy link
Copy Markdown
Contributor

Picks up dfinity/ci-tools#94. bdfe993..a98f5d0 is only that commit.

Since reuse_branch (dfinity/ci-tools#80), the changelog pull request is force pushed on every push to main, and those pushes came from the default token as github-actions[bot]. Its workflows then waited for approval, and required pull_request_target workflows such as the External PR Ruleset never ran, which blocks the pull request even when approved (e.g. dfinity/pic-js#290). With #94, the branch is pushed with the app token instead.

🤖 Generated with Claude Code

@marc0olo
marc0olo requested a review from a team as a code owner September 25, 2026 14:06
@zeropath-ai

zeropath-ai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

✅ No security or compliance issues detected. Reviewed everything up to 3dfc822.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► .github/workflows/create-release-pr.yml
      Replace various dfinity/ci-tools action versions with a98f5d0198719ad41ded2f02fa0f5e426102f369 for setup-python, setup-commitizen, setup-pnpm, bump-version, and create-pr # main
► .github/workflows/docs.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/e2e-tests.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/generate-changelog.yml
      Update generate-changelog workflow to use a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/lint.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/mitm.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/npm-audit.yml
      Update setup-pnpm and create-pr action versions to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/prettier.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/publish-docs.yml
      Update setup-pnpm and extract-version/assemble-docs/submit-docs actions to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/release.yml
      Update setup-python, setup-commitizen, setup-pnpm, is-beta-tag, extract-version, generate-release-notes to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/size-limit.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main
► .github/workflows/unit-tests.yml
      Update setup-pnpm action version to a98f5d0198719ad41ded2f02fa0f5e426102f369 # main

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@icp-sdk/core 91 B (0%)
@icp-sdk/core/agent 53.35 KB (0%)
@icp-sdk/core/candid 13.7 KB (0%)
@icp-sdk/core/identity 21.38 KB (0%)
@icp-sdk/core/identity/secp256k1 33.73 KB (0%)
@icp-sdk/core/principal 4.38 KB (0%)

@marc0olo
marc0olo merged commit 82c5df5 into main Sep 25, 2026
25 checks passed
@marc0olo
marc0olo deleted the build/ci-tools-a98f5d0 branch September 25, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants