Skip to content

chore(motoko): sync caffeinelabs/skills ee8e3dd - #410

Merged
raymondk merged 2 commits into
mainfrom
chore/sync-upstream-skills-ee8e3dd
Sep 30, 2026
Merged

raymondk merged 2 commits into
mainfrom
chore/sync-upstream-skills-ee8e3dd

Conversation

@marc0olo

@marc0olo marc0olo commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Syncs caffeinelabs/skills e6277b7 → ee8e3dd.

Upstream changed what counts as a pending migration. It used to mean a migration created in the current build. It now means a migration that has not been applied yet. The edit and freeze rules follow from that: a pending migration gets edited, and an applied one is frozen. The rewording covers all four Motoko skills (writing-motoko, migrating-motoko-actors, troubleshooting-motoko-migrations, reviewing-motoko plus references/state-and-persistence.md). No upstream files were added or removed, and no icskills-owned sections were affected. .claude/upstream.md has the new commit and upstream versions.

New eval migrating-motoko-actors #9: a migration written in an earlier session and never deployed is still pending, so the next change is folded into it and does not go in a second file.

This sync leaves a few unchanged upstream lines that still say to always add a new migration file. They contradict the new rule, so I filed them upstream as caffeinelabs/skills#15 rather than patching them here.

Eval results (new case 9, with baseline)
WITH skill: 3/3 passed
  ✅ Edits the existing `20260929_101500.mo` to add `tags` alongside `priority`, instead of creating a second migration file
  ✅ Explains the file is still pending because it was never applied (deployed), so it is not frozen even though it was written in an earlier session
  ✅ Notes that at most one pending migration is allowed (`check-limit = 1`), so a second file would be rejected

WITHOUT skill: 2/3 passed
  ✅ Edits the existing `20260929_101500.mo` ...
  ✅ Explains the file is still pending ...
  ❌ Notes that at most one pending migration is allowed (`check-limit = 1`), so a second file would be rejected

Closes #408

Redefine a pending migration as one not yet applied, rather than one
created in the current build, across writing-motoko,
migrating-motoko-actors, troubleshooting-motoko-migrations and
reviewing-motoko. Add an eval for an undeployed migration left over
from an earlier session.
@github-actions

Copy link
Copy Markdown

Skill Validation Report

Project Checks


✓ Project checks passed for 4 skills (0 warnings)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Several unchanged instructions still mandate new files or describe all migrations as frozen, contradicting the new pending-migration behavior.

Review effort: Balanced
Findings: 3 Medium severity · 1 Low severity

Open (4)
What changed in this PR

Synchronizes Motoko migration guidance with upstream’s deployment-based definition of pending migrations.

Changes:

  • Clarifies pending versus applied migration rules.
  • Adds an eval for undeployed migrations from earlier sessions.
  • Updates upstream tracking metadata.
File Description
skills/​writing-motoko/​SKILL.md Updates migration freeze terminology.
skills/​migrating-motoko-actors/​SKILL.md Revises pending migration guidance.
skills/​troubleshooting-motoko-migrations/​SKILL.md Clarifies editable pending migrations.
skills/​reviewing-motoko/​SKILL.md Updates migration review criteria.
skills/​reviewing-motoko/​references/​state-and-persistence.md Revises applied-migration guidance.
evaluations/​migrating-motoko-actors.json Adds the undeployed-migration regression case.
.claude/​upstream.md Records the new upstream commit and versions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread skills/migrating-motoko-actors/SKILL.md
Comment thread skills/reviewing-motoko/SKILL.md
Comment thread skills/writing-motoko/SKILL.md
Comment thread evaluations/migrating-motoko-actors.json Outdated
@marc0olo
marc0olo marked this pull request as ready for review September 30, 2026 07:28
@marc0olo
marc0olo requested review from a team and JoshDFN as code owners September 30, 2026 07:28
@raymondk
raymondk merged commit 8edff1f into main Sep 30, 2026
6 checks passed
@raymondk
raymondk deleted the chore/sync-upstream-skills-ee8e3dd branch September 30, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upstream sync available — caffeinelabs/skills e6277b7 → ee8e3dd

4 participants